[Woo POS][App Listings] ASC promo screenshots #16405
Merged
+106
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
iamgabrielma
added
the
generate screenshots
Collaborator
|
|
Despite tests passing, the contents of the pos-payment screenshot was incorrect, as lands on the failure case for `checkOrderIsStillEligibleForPayment` when attempting to retrieve the order details, hence showing a “Error: unable to process payment. we could not fetch the latest order details” rather than the payment view. Despite passing the CPP mock in the POSTabCoordinator, we were never setting it in the test as a launch argument.
Since we run the notification screenshot the last one due to the UI test flow, when we run the create_promo lane then screenshot descriptions are miss-aligned with what they show which fails the job.
At the moment we intersect POS screenshots, but “product-add” screenshot happens as the 7th, while in screenshots.js is set to be the 4rth. This fails the create_promo job as cannot find the correct index along the screenshot name
iamgabrielma
removed
the
generate screenshots
initial attempt to set the screenshot landscape composition programmatically. might need iteration after checking the result artifacts
iamgabrielma
added
the
generate screenshots
iPhone screenshots 4 and 5 are using the wrong text files because new POS screenshots are inserted into the sequence
Contributor
Author
|
For some reason, marking the PR as ready seems to have triggered the screenshots job again, Edit: Latest screenshots can be found here: https://github.com/woocommerce/woocommerce-ios/actions/runs/20289167160/job/58286405158?pr=16405 |
iamgabrielma
removed
the
generate screenshots
joshheald
approved these changes
Dec 19, 2025
Contributor
joshheald
left a comment
joshheald
left a comment
There was a problem hiding this comment.
Well done for wrangling this, screenshots look good
iamgabrielma
deleted the
task/WOOMOB-1644-generate-pos-promo-screenshots
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes WOOMOB-1644
Description
This PR handles creating the new POS promotional screenshots and submitting them to the App Store through our existing fastlane automation.
Changes
fastfileto include the new mappingapp_store_screenshot->promo_screenshotscreenshots.jsonto include a new landscape device, mostly mapping the existing portrait one. These are mounted programmatically by pixel/pixel-offset, but there is no references anywhere, so was a bit of iteration to make them fit adequately:iPad
iPhones
Test Steps
WooCommerceScreenshots.testScreenshots()both in iPad and iPhone as your run destination, they should pass (some UI tests are a bit flaky, but on a second run they should normally pass correctly)https://github.com/woocommerce/woocommerce-ios/actions/runs/20289167160/job/58286405158?pr=16405underProcess screenshots> Archive promo screenshots > Download the artifacts to see all screenshots for all locales (the untranslated screenshots will show a placeholder rather than their text)Example for Spanish, where the POS appears in Spanish locale, and the metadata text is just untranslated placeholder:
RELEASE-NOTES.txtif necessary.